[client] Unify query-param style: params= everywhere (f-string query concat in several reads) #185
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Query-string construction splits between two styles:
switch_capacity(_capacities.py:25,.../switch?enable={...}),get_devices(_devices.py:23,.../devices?siteId={site_id});params=: the siblingset_pilot_wire(_capacities.py:44), the whole aggregations module.The
params=style URL-encodes values and keeps query keys greppable; the f-string style risks encoding bugs the day a value contains&, spaces or unicode —site_uidvalues are opaque strings, so this is not hypothetical.Fix: use
params=everywhere. Purely internal (request URLs identical for current inputs), so no API change; existing tests keep asserting the same query strings.Done when: no f-string query construction remains in
comwatt_client/,pytest -qgreen.