mat/homeassistant-comwatt
1
0
Fork 0
Code Issues Pull requests 6 Projects Releases Packages Activity Actions

🐛 Fix NameError in AutoProductionRate sensor #11

Merged
mat merged 1 commit from fix/c1-auto-production-rate into main 2026-04-24 13:43:20 +00:00
Conversation 0 Commits 1 Files changed 3 +3 -11
mat commented 2026-04-24 13:34:19 +00:00
Owner
Copy link

Summary

  • ComwattAutoProductionRateSensor.update assigned self._attr_native_value = auto_production_rate — an undefined name — on every poll. The except Exception below silently swallowed the NameError and triggered a full re-auth cycle every time the sensor updated.
  • The correct assignment already lives a few lines down, reading the last bucket of autoproductionRates as a percentage.
  • Drop the dead line.

Side-effects

  • The xfail marker on tests/test_sensor.py::test_auto_production_rate_reads_latest_value is removed; the test now passes normally.
  • The F821 entry in the ruff ignore list (which was only there for this specific NameError) is removed.

Test plan

  • pytest tests/test_sensor.py — 6 passed locally (was 5 passed + 1 xfailed).
  • ruff check . — still green with F821 no longer ignored.
## Summary - `ComwattAutoProductionRateSensor.update` assigned `self._attr_native_value = auto_production_rate` — an undefined name — on every poll. The `except Exception` below silently swallowed the `NameError` and triggered a full re-auth cycle every time the sensor updated. - The correct assignment already lives a few lines down, reading the last bucket of `autoproductionRates` as a percentage. - Drop the dead line. ## Side-effects - The xfail marker on `tests/test_sensor.py::test_auto_production_rate_reads_latest_value` is removed; the test now passes normally. - The `F821` entry in the ruff ignore list (which was only there for this specific NameError) is removed. ## Test plan - [x] `pytest tests/test_sensor.py` — 6 passed locally (was 5 passed + 1 xfailed). - [x] `ruff check .` — still green with `F821` no longer ignored.
🐛 Fix NameError in AutoProductionRate sensor
All checks were successful
Validate / validate-hacs (push) Has been skipped
Details
Validate / validate-hassfest (push) Has been skipped
Details
Validate / lint-ruff (push) Successful in 6s
Details
Validate / test-pytest (push) Successful in 1m45s
Details
Validate / type-check-mypy (push) Successful in 1m49s
Details
Validate / validate-hacs (pull_request) Has been skipped
Details
Validate / validate-hassfest (pull_request) Has been skipped
Details
Validate / lint-ruff (pull_request) Successful in 6s
Details
Validate / test-pytest (pull_request) Successful in 1m44s
Details
Validate / type-check-mypy (pull_request) Successful in 1m49s
Details
f0419a974e 
`ComwattAutoProductionRateSensor.update` assigned `self._attr_native_value`
to an undefined name `auto_production_rate`, producing a `NameError` on
every poll. The bare `except Exception` silently forced a re-auth on each
occurrence. The correct assignment already existed below, reading the
percentage from the time series.

Remove the dead line. The fix causes the xfail-marked sensor test to
start passing, so its marker is dropped, and the `F821` entry that was
only tracking this specific case is removed from the ruff ignore list.
mat merged commit cab165707f into main 2026-04-24 13:43:20 +00:00
mat deleted branch fix/c1-auto-production-rate 2026-04-24 13:43:20 +00:00
mat referenced this pull request from a commit 2026-04-24 14:26:33 +00:00
🔖 Release v0.3.2 (#15)
mat referenced this pull request from a commit 2026-04-24 21:51:56 +00:00
🐛 Fix KeyError in async_unload_entry
mat referenced this pull request from a commit 2026-04-24 21:51:56 +00:00
🔖 Release v0.3.2
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mat/homeassistant-comwatt!11
No description provided.