mat/homeassistant-comwatt
Watch
1
0
Fork
You've already forked homeassistant-comwatt
 0
Code Issues 36 Pull requests 1 Projects Releases Packages Activity Actions

♻️ Extract _try_fetch helper to collapse try/except duplication #47

Merged
mat merged 1 commit from refactor/try-fetch-helper into main 2026-07-10 18:01:19 +00:00
Conversation 0 Commits 1 Files changed 1 +27 -36
mat commented 2026-07-10 16:55:17 +00:00
Owner
Copy link

Pure, behavior-preserving refactor of coordinator.py.

Collapses the 4 repeated try/except ComwattAuthError: raise / except Exception: <fallback> blocks (site time-series, device power, device energy, switch refresh) into a single _try_fetch(fn, *args) helper that re-raises auth errors and returns None on any other failure. Call sites guard with is not None / or {}.

  • 32/32 tests pass, ruff clean.
  • Part of a 5-PR simplification pass (1 PR per point).
Pure, behavior-preserving refactor of `coordinator.py`. Collapses the 4 repeated `try/except ComwattAuthError: raise / except Exception: <fallback>` blocks (site time-series, device power, device energy, switch refresh) into a single `_try_fetch(fn, *args)` helper that re-raises auth errors and returns `None` on any other failure. Call sites guard with `is not None` / `or {}`. - 32/32 tests pass, ruff clean. - Part of a 5-PR simplification pass (1 PR per point).
♻️ Extract _try_fetch helper to collapse try/except duplication
All checks were successful
Validate / lint-ruff (push) Successful in 7s
Details
Validate / test-pytest (push) Successful in 2m59s
Details
Validate / type-check-mypy (push) Successful in 3m7s
Details
Validate / lint-ruff (pull_request) Successful in 7s
Details
Validate / test-pytest (pull_request) Successful in 3m0s
Details
Validate / type-check-mypy (pull_request) Successful in 3m7s
Details
a33571367a
mat merged commit 867cd51e74 into main 2026-07-10 18:01:19 +00:00
mat deleted branch refactor/try-fetch-helper 2026-07-10 18:01:20 +00:00
mat referenced this pull request from a commit 2026-07-10 18:06:30 +00:00
🔖 Release v0.6.0
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
v1.0 · bloquant
À corriger absolument avant la release v1.0

  
v1.0 · majeur
Fortement recommandé avant la v1.0

  
v1.0 · mineur
Polish / robustesse, non bloquant

No labels
v1.0 · bloquant
v1.0 · majeur
v1.0 · mineur
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mat/homeassistant-comwatt!47
No description provided.