mat/homeassistant-comwatt
1
0
Fork 0
Code Issues 1 Pull requests 1 Projects Releases Packages Activity Actions

♻️ Extract _find_switch_capacity to collapse switch-capacity scan #48

Merged
mat merged 1 commit from refactor/find-switch-capacity into main 2026-07-13 12:49:39 +00:00
Conversation 0 Commits 1 Files changed 1 +11 -15
mat commented 2026-07-10 16:55:25 +00:00
Owner
Copy link

Pure, behavior-preserving refactor of coordinator.py.

Collapses the duplicated features→capacities→nature scan (previously in both _has_switch_capacity and _fetch_switch_state) into a single static _find_switch_capacity helper, and removes _has_switch_capacity.

⚠️ Stacked on #47 — this PR targets refactor/try-fetch-helper, not main. Merge #47 first; this PR will then retarget to main.

Note: this aligns _fetch_switch_state with the first-match semantics that _has_switch_capacity already used. The old inner-loop break returned the last feature's match for a multi-feature device — a latent inconsistency, not exercised by any test.

  • 32/32 tests pass, ruff clean.
Pure, behavior-preserving refactor of `coordinator.py`. Collapses the duplicated features→capacities→nature scan (previously in **both** `_has_switch_capacity` and `_fetch_switch_state`) into a single static `_find_switch_capacity` helper, and removes `_has_switch_capacity`. ⚠️ **Stacked on #47** — this PR targets `refactor/try-fetch-helper`, not `main`. Merge #47 first; this PR will then retarget to `main`. Note: this aligns `_fetch_switch_state` with the first-match semantics that `_has_switch_capacity` already used. The old inner-loop `break` returned the *last* feature's match for a multi-feature device — a latent inconsistency, not exercised by any test. - 32/32 tests pass, ruff clean.
♻️ Extract _find_switch_capacity to collapse switch-capacity scan
All checks were successful
Validate / lint-ruff (push) Successful in 7s
Details
Validate / test-pytest (push) Successful in 2m59s
Details
Validate / type-check-mypy (push) Successful in 3m8s
Details
Validate / lint-ruff (pull_request) Successful in 7s
Details
Validate / test-pytest (pull_request) Successful in 2m59s
Details
Validate / type-check-mypy (pull_request) Successful in 3m7s
Details
ddcb75284f
mat changed target branch from refactor/try-fetch-helper to main 2026-07-10 18:01:20 +00:00
mat force-pushed refactor/find-switch-capacity from ddcb75284f
All checks were successful
Validate / lint-ruff (push) Successful in 7s
Details
Validate / test-pytest (push) Successful in 2m59s
Details
Validate / type-check-mypy (push) Successful in 3m8s
Details
Validate / lint-ruff (pull_request) Successful in 7s
Details
Validate / test-pytest (pull_request) Successful in 2m59s
Details
Validate / type-check-mypy (pull_request) Successful in 3m7s
Details
to 577546f09a
All checks were successful
Validate / lint-ruff (push) Successful in 7s
Details
Validate / test-pytest (push) Successful in 2m59s
Details
Validate / type-check-mypy (push) Successful in 3m7s
Details
Validate / lint-ruff (pull_request) Successful in 7s
Details
Validate / test-pytest (pull_request) Successful in 2m59s
Details
Validate / type-check-mypy (pull_request) Successful in 3m8s
Details
2026-07-10 18:26:05 +00:00 Compare
mat merged commit 5b98c7756c into main 2026-07-13 12:49:39 +00:00
mat deleted branch refactor/find-switch-capacity 2026-07-13 12:49:39 +00:00
mat referenced this pull request from a commit 2026-07-13 13:03:58 +00:00
🔖 Release v0.6.1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
mat/homeassistant-comwatt!48
No description provided.