mat/homeassistant-comwatt

Watch

Fork 0

✅ Add sensor tests #6

Merged

mat merged 3 commits from test/sensor into main

2026-04-24 12:38:53 +00:00

mat commented

2026-04-24 11:28:27 +00:00

Owner

Summary

Adds tests/test_sensor.py with 6 cases:
- Empty site list → no sensors.
- Leaf device → power, energy, auto-production-rate.
- Parent + partChilds → power+energy per child (not on the parent).
- ComwattPowerSensor reads values[-1] with correct unit/device-class/state-class.
- ComwattEnergySensor accumulates a delta (documents current shipped behavior; see finding H4).
- ComwattAutoProductionRateSensor marked xfail against finding C1 (undefined auto_production_rate).

Depends on

#3 (test infrastructure).

Test plan

pytest tests/test_sensor.py — 5 passed, 1 xfailed
When C1 lands, the xfail should flip to passing; that PR should drop the marker.

Notes

The energy-sensor test locks in the current client-side accumulator semantics. Finding H4 argues for switching to a cumulative API counter — the test should be rewritten in that PR, not before, so any accidental state-class / unit regression is caught in the meantime.

## Summary - Adds `tests/test_sensor.py` with 6 cases: - Empty site list → no sensors. - Leaf device → power, energy, auto-production-rate. - Parent + `partChilds` → power+energy per child (not on the parent). - `ComwattPowerSensor` reads `values[-1]` with correct unit/device-class/state-class. - `ComwattEnergySensor` accumulates a delta (documents current shipped behavior; see finding H4). - `ComwattAutoProductionRateSensor` marked **xfail** against finding **C1** (undefined `auto_production_rate`). ## Depends on - #3 (test infrastructure). ## Test plan - [x] `pytest tests/test_sensor.py` — 5 passed, 1 xfailed - [ ] When C1 lands, the xfail should flip to passing; that PR should drop the marker. ## Notes - The energy-sensor test locks in the *current* client-side accumulator semantics. Finding H4 argues for switching to a cumulative API counter — the test should be rewritten in that PR, not before, so any accidental state-class / unit regression is caught in the meantime.

mat added 3 commits

2026-04-24 11:28:27 +00:00

✅ (AI) Add pytest infrastructure

Validate / validate-hacs (push) Failing after 2s

Details

Validate / validate-hassfest (push) Failing after 2s

Details

Validate / validate-hacs (pull_request) Failing after 2s

Details

Validate / validate-hassfest (pull_request) Failing after 2s

Details

253d3d9515

Adds the plumbing needed to run Home Assistant custom-integration tests:

- `requirements-test.txt` pins `pytest-homeassistant-custom-component`
  (which transitively pulls `homeassistant`) and the runtime dependency
  `comwatt-client`.
- `pytest.ini` enables `asyncio_mode = auto` and points pytest at
  `tests/`.
- `tests/conftest.py` loads the pytest-homeassistant-custom-component
  plugin, auto-enables custom integrations, and exposes a
  `mock_comwatt_client` fixture that patches every import site of
  `ComwattClient` used by the integration.
- `tests/test_smoke.py` exercises the plumbing and asserts basic
  manifest/domain invariants.

Follow-up PRs will add config-flow, init, sensor, and switch tests on
top of this scaffolding.

🐛 (AI) Fix cookie jar mock in test fixture

Validate / validate-hacs (push) Failing after 2s

Details

Validate / validate-hassfest (push) Failing after 2s

Details

Validate / validate-hacs (pull_request) Failing after 2s

Details

Validate / validate-hassfest (pull_request) Failing after 2s

Details

05511bb47b

`_make_fake_client` assigned a plain list to `session.cookies` then
tried to attach a `get_dict` attribute to it, which fails because
lists don't accept arbitrary attributes. Introduce `_FakeCookieJar`, a
list subclass that answers `get_dict()` the way `requests`' own
`RequestsCookieJar` does, so both iteration (used by the config flow)
and `get_dict()` (used by the integration to snapshot the session)
work against the mock.

✅ (AI) Add sensor tests

Validate / validate-hacs (push) Failing after 2s

Details

Validate / validate-hassfest (push) Failing after 2s

Details

Validate / validate-hacs (pull_request) Failing after 2s

Details

Validate / validate-hassfest (pull_request) Failing after 2s

Details

c741403b7e

Covers the three sensor classes and the device-discovery walk:

- Empty site list → no sensor entities registered.
- Site with one leaf device → auto-production-rate, power, energy.
- Site with a parent that has `partChilds` → power+energy per child
  (no sensors on the parent itself).
- `ComwattPowerSensor` reports `values[-1]` with correct unit, device
  class, and state class.
- `ComwattEnergySensor` accumulates deltas (documents current shipped
  behavior; finding H4 proposes replacing this with a cumulative
  counter — the test should be rewritten when that lands).
- `ComwattAutoProductionRateSensor` is marked xfail against finding
  C1 (undefined `auto_production_rate` reference).

mat force-pushed test/sensor from c741403b7e

Validate / validate-hacs (push) Failing after 2s

Details

Validate / validate-hassfest (push) Failing after 2s

Details

Validate / validate-hacs (pull_request) Failing after 2s

Details

Validate / validate-hassfest (pull_request) Failing after 2s

Details

to 0ad95aa9d0

Validate / validate-hacs (push) Failing after 2s

Details