♻️ Move site rate ×100 scalar into the sensor #45

Merged

mat merged 1 commit from refactor/site-rate-scalar-in-sensor into main

2026-07-10 15:05:31 +00:00

mat commented

2026-07-10 14:47:51 +00:00

Owner

Why

#19 duplicated the "is this a rate?" knowledge in two places that can silently drift apart:

coordinator.py → _RATE_KEYS decided the ×100
sensor.py → SITE_METRICS decided the PERCENTAGE unit

Add a rate key to one set and forget the other → a ×100 value surfaced in Wh, or a raw 0-1 ratio surfaced in %. No test caught that direction.

Change

The coordinator now stores the raw 0-1 ratio for rates; _RATE_KEYS is deleted.
The sensor applies ×100 when its native_unit_of_measurement == PERCENTAGE — the single source of truth, next to the unit it already owns.

Behavior

Unchanged at the entity level: test_auto_production_rate_reads_latest_value (0.42 → 42.0) and test_site_metrics_expose_every_known_key (0.75 → 75.0) still pass as-is. Re-adding ×100 to the coordinator would double-scale and make 0.42 → 4200, so the existing tests lock the new contract.

Test plan

pytest — 32 passed
ruff + mypy clean

## Why `#19` duplicated the "is this a rate?" knowledge in two places that can silently drift apart: - `coordinator.py` → `_RATE_KEYS` decided the ×100 - `sensor.py` → `SITE_METRICS` decided the `PERCENTAGE` unit Add a rate key to one set and forget the other → a ×100 value surfaced in Wh, or a raw 0-1 ratio surfaced in %. No test caught that direction. ## Change - The coordinator now stores the **raw 0-1 ratio** for rates; `_RATE_KEYS` is deleted. - The sensor applies ×100 when its `native_unit_of_measurement == PERCENTAGE` — the single source of truth, next to the unit it already owns. ## Behavior Unchanged at the entity level: `test_auto_production_rate_reads_latest_value` (`0.42 → 42.0`) and `test_site_metrics_expose_every_known_key` (`0.75 → 75.0`) still pass as-is. Re-adding ×100 to the coordinator would double-scale and make `0.42 → 4200`, so the existing tests lock the new contract. ## Test plan - [x] pytest — 32 passed - [x] ruff + mypy clean

mat added 1 commit

2026-07-10 14:47:51 +00:00

♻️ Move site rate ×100 scalar into the sensor

Validate / lint-ruff (push) Waiting to run

Details

Validate / test-pytest (push) Waiting to run

Details

Validate / type-check-mypy (push) Waiting to run

Details

Validate / lint-ruff (pull_request) Waiting to run

Details

Validate / test-pytest (pull_request) Waiting to run

Details

Validate / type-check-mypy (pull_request) Waiting to run

Details

0dcacd6320

The 'is this a rate' knowledge was duplicated: _RATE_KEYS in the
coordinator (decided ×100) and SITE_METRICS in the sensor (decided the
PERCENTAGE unit). Adding a rate to one set and forgetting the other would
silently surface a ×100 value in Wh (or vice-versa).

The coordinator now stores the raw 0-1 ratio; the sensor applies ×100
when its unit is PERCENTAGE — the single source of truth. Behavior is
unchanged at the entity level (existing rate tests still pass).

mat changed target branch from feat/40-site-metrics to main

2026-07-10 14:59:01 +00:00

mat force-pushed refactor/site-rate-scalar-in-sensor from 0dcacd6320

Validate / lint-ruff (push) Waiting to run

Details

Validate / test-pytest (push) Waiting to run

Details

Validate / type-check-mypy (push) Waiting to run

Details

Validate / lint-ruff (pull_request) Waiting to run

Details

Validate / test-pytest (pull_request) Waiting to run