♻️ refactor: use params= for query strings everywhere #204
Loading…
Reference in a new issue
No description provided.
Delete branch "refactor/params-style"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Every f-string query construction moves to
params=(#185) — 12 sites, not just the two the issue cited:params=URL-encodes values and keeps query keys greppable;site_uid/gateway_uidare opaque strings, so the f-string route was an encoding bug waiting to happen.Evidence
grep 'f"/.*?.*{' comwatt_client/returned 12 query-building sites.After: the grep returns nothing.
pytest -q→ 242 passed with zero test edits — every existing query-string assertion (siteId, deviceId, enable=true/false, page merging) passes unchanged, proving the wire is identical.mypy→ clean.Merge Danger
Door: two-way
Blast Radius: low — same URLs for all current inputs. Note: #199 (paginate hardening) rewrites part of the old
_paginatethis PR replaces; whichever merges first, I will rebase the other myself (the page-cap guard moves into the newparamsloop).Closes #185.
2013bfddf15f69ff8c0eWIP: ♻️ refactor: use params= for query strings everywhereto ♻️ refactor: use params= for query strings everywhere