✨ Add configurable request timeout to all HTTP calls #8

Merged

mat merged 1 commit from feat/request-timeouts into main 2026-07-04 07:41:51 +00:00

Conversation 0 Commits 1 Files changed 1 +12 -11

mat commented 2026-07-04 07:40:09 +00:00

Owner

Copy link

P0 bug fix #5/5.

None of the HTTP calls passed a timeout, so a hung connection blocks the caller forever (bad for the Home Assistant integration). Adds ComwattClient(timeout=30) and passes timeout=self.timeout to all 10 request calls. Default 30 s, configurable per instance. Backward compatible (ComwattClient() still works). py_compile passes; all 10 calls verified to carry the timeout.

**P0 bug fix #5/5.** None of the HTTP calls passed a `timeout`, so a hung connection blocks the caller forever (bad for the Home Assistant integration). Adds `ComwattClient(timeout=30)` and passes `timeout=self.timeout` to all 10 request calls. Default 30 s, configurable per instance. Backward compatible (`ComwattClient()` still works). `py_compile` passes; all 10 calls verified to carry the timeout.

mat added 1 commit 2026-07-04 07:40:09 +00:00

✨ Add configurable request timeout to all HTTP calls 5bef709eaa

mat merged commit ad1eb4d0bf into main 2026-07-04 07:41:51 +00:00

mat deleted branch feat/request-timeouts 2026-07-04 07:41:51 +00:00

mat referenced this pull request from a commit 2026-07-04 07:41:53 +00:00

✨ Add configurable request timeout to all HTTP calls (#8)

mat referenced this pull request 2026-07-04 07:50:17 +00:00

✅ Fix CI: switch_capacity tests expect lowercase enable #9

mat referenced this pull request from a commit 2026-07-04 07:52:53 +00:00

✅ Fix CI: switch_capacity tests expect lowercase enable (#9)

mat referenced this pull request 2026-07-04 08:56:54 +00:00

♻️ Route HTTP calls through a central _request() helper #14

mat referenced this pull request 2026-07-04 09:07:02 +00:00

✨ Auto re-authenticate and retry once on 401 #15

mat referenced this pull request from a commit 2026-07-04 09:08:05 +00:00

♻️ Route HTTP calls through a central _request() helper

mat referenced this pull request from a commit 2026-07-04 09:10:44 +00:00

✨ Auto re-authenticate and retry once on 401 (#15)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

mat/python-comwatt-client!8

No description provided.