✨ Auto re-authenticate and retry once on 401 #15

Merged

mat merged 2 commits from feat/auto-reauth into main

2026-07-04 09:10:42 +00:00

mat commented

2026-07-04 09:07:02 +00:00

Owner

Slice 2 of 2 — point #8 (session-expiry handling)

Stacked on #14 (base branch refactor/central-request-helper). Review/merge #14 first; this diff shows only the re-auth changes.

Transparent auto re-authentication: on a 401 the client silently re-logs-in once
(reusing credentials captured at authenticate() time) and retries the request once.
This is exactly what the Home Assistant integration needs to stop falling into
ConfigEntryAuthFailed every time the cwt_session cookie expires.

Design (agreed with maintainer):

ComwattClient(auto_reauth=True) — new flag, on by default; auto_reauth=False disables.
Hash-only credential retention — stores username + the sha256 hash, never the raw password.
Re-auth + retry logic lives only in the central _request helper; one retry, no loop.
Only 401 triggers it. 403 keeps raising ComwattAPIError.
authenticate() and is_authenticated() never auto-retry (the auth probe still returns True/False).

Tests: +6 (tests/test_reauth.py) covering happy path, auto_reauth=False, no-stored-creds,
re-auth-then-still-401 (single retry), is_authenticated unaffected, and no-raw-password-retained.
Full suite green (38 passed).

Draft (WIP) — remove the WIP prefix to mark ready for review.

## Slice 2 of 2 — point #8 (session-expiry handling) **Stacked on #14** (base branch `refactor/central-request-helper`). Review/merge #14 first; this diff shows only the re-auth changes. Transparent auto re-authentication: on a **401** the client silently re-logs-in once (reusing credentials captured at `authenticate()` time) and retries the request once. This is exactly what the Home Assistant integration needs to stop falling into `ConfigEntryAuthFailed` every time the `cwt_session` cookie expires. Design (agreed with maintainer): - `ComwattClient(auto_reauth=True)` — new flag, on by default; `auto_reauth=False` disables. - **Hash-only credential retention** — stores `username` + the sha256 hash, never the raw password. - Re-auth + retry logic lives only in the central `_request` helper; **one** retry, no loop. - **Only 401** triggers it. **403** keeps raising `ComwattAPIError`. - `authenticate()` and `is_authenticated()` never auto-retry (the auth probe still returns `True`/`False`). **Tests:** +6 (`tests/test_reauth.py`) covering happy path, `auto_reauth=False`, no-stored-creds, re-auth-then-still-401 (single retry), `is_authenticated` unaffected, and no-raw-password-retained. Full suite green (38 passed). _Draft (WIP) — remove the WIP prefix to mark ready for review._

mat added 1 commit

2026-07-04 09:07:02 +00:00