✨ feat: catalogue methods (get_products, get_timezones, get_modbus_configurations) #153
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/catalogue-methods"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Three catalogue reads from issue #97, all live-verified 200 (2026-10-11 lineage, see
docs/energy.comwatt.com/misc-endpoints.md+devices.md):{id, name, brand, cardinality, features}){timeZone, posix}pairsdevice_kindskey is snake_case (documented, passed through as-is). Pairing (POST /devices/v2/modbus) stays out — installer flow.Follow-ups tracked separately:
get_product(product_id)(#152), mixin/proxy architecture audit (#151).Evidence
AttributeError: 'ComwattClient' object has no attribute 'get_modbus_configurations'— methods didn't exist; baselinepytest= 173 passed.tests/test_catalogues.py: happy path + 500→ComwattAPIErrorper method, asserting method/path/query);pytest= 179 passed;mypyclean.Merge Danger
Door: two-way — purely additive; revert restores the previous client exactly.
Blast Radius: minimal — 3 new public methods, no existing method touched; one mixin added to the MRO chain of
ComwattClient.Closes #97
WIP: ✨ feat: catalogue methods (get_products, get_timezones, get_modbus_configurations)to ✨ feat: catalogue methods (get_products, get_timezones, get_modbus_configurations)