[client] Audit mixin/proxy architecture once read-only surface is complete (merge, relocate, or unify) #151
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Once the read-only client surface (roadmap section 3) is fully shipped, do a
global architecture review of the
ComwattClientcomposition:WeatherProxy(client.weather.*, unauthenticated base URL), every otherdomain is a flat mixin (
client.get_*). Decide when a domain deserves aproxy and apply the rule uniformly.
capacities, devices, gateways, grid, plannings, sites, connected-objects,
streaming, electricity-contracts, typical-days, thermal-control,
weather-proxy — plus the incoming catalogues mixin. Some are thin (one or
two methods), some overlap semantically (typical-days vs plannings vs
thermal-control; aggregations vs grid vs series).
misplaced methods (e.g.
get_device_kindssits in DevicesMixin despitebeing a catalogue read)? does the MRO /
_BaseClientsplit still hold?should anything become a proxy?
Constraint: public API compatibility — moving methods between private modules
is free, renaming/removing public methods needs a deprecation path.
Deferred until #97 and the remaining read-only issues (#98, #102, #103,
#106…) are merged, so the review sees the final shape.