♻️ refactor: merge plannings + typical days into SchedulingMixin #195

Merged
mat merged 1 commit from refactor/merge-scheduling into main 2026-10-27 14:36:17 +00:00
Owner

Summary

The two scheduling-domain mixins merge into one module and one class — plannings embed typicalDaySchedules, so the split was accidental (#151 audit):

_plannings.py    ─┐
_typical_days.py ─┴─► _scheduling.py, SchedulingMixin
    ├── get_plannings · update_planning
    └── get_typical_days · create_typical_day · update_typical_day

client.py: PlanningsMixin + TypicalDaysMixin imports/bases → SchedulingMixin (16 → 15 mixins)

git mv keeps the diff minimal (rename detection 56%).

Evidence

  • Before: plannings and typical days lived in two modules despite the same domain.
    After: one SchedulingMixin; no test imports the deleted modules (verified), pytest -q → 242 passed unchanged, mypy → clean.

Merge Danger

Door: two-way

Blast Radius: none — public API unchanged (all five flat methods identical); only the client.py bases line overlaps with sibling consolidation PRs.

Closes the plannings/typical-days part of #176. Part of the #151 audit consolidation.

## Summary The two scheduling-domain mixins merge into one module and one class — plannings embed `typicalDaySchedules`, so the split was accidental (#151 audit): ```text _plannings.py ─┐ _typical_days.py ─┴─► _scheduling.py, SchedulingMixin ├── get_plannings · update_planning └── get_typical_days · create_typical_day · update_typical_day client.py: PlanningsMixin + TypicalDaysMixin imports/bases → SchedulingMixin (16 → 15 mixins) ``` `git mv` keeps the diff minimal (rename detection 56%). ## Evidence - **Before:** plannings and typical days lived in two modules despite the same domain. **After:** one `SchedulingMixin`; no test imports the deleted modules (verified), `pytest -q` → 242 passed unchanged, `mypy` → clean. ## Merge Danger **Door:** two-way **Blast Radius:** none — public API unchanged (all five flat methods identical); only the `client.py` bases line overlaps with sibling consolidation PRs. Closes the plannings/typical-days part of #176. Part of the #151 audit consolidation.
♻️ refactor: merge plannings + typical days into SchedulingMixin
All checks were successful
Tests / forgejo-pytest (push) Successful in 44s
Tests / forgejo-pytest (pull_request) Successful in 44s
30a2baa8d5
mat force-pushed refactor/merge-scheduling from 30a2baa8d5
All checks were successful
Tests / forgejo-pytest (push) Successful in 44s
Tests / forgejo-pytest (pull_request) Successful in 44s
to 7eae1ce9ae
All checks were successful
Tests / forgejo-pytest (push) Successful in 46s
Tests / forgejo-pytest (pull_request) Successful in 46s
2026-10-27 14:36:08 +00:00
Compare
mat changed title from WIP: ♻️ refactor: merge plannings + typical days into SchedulingMixin to ♻️ refactor: merge plannings + typical days into SchedulingMixin 2026-10-27 14:36:16 +00:00
mat merged commit d51a799b99 into main 2026-10-27 14:36:17 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mat/python-comwatt-client!195
No description provided.