♻️ refactor: fold ThermalControlMixin into CapacitiesMixin #193

Merged
mat merged 1 commit from refactor/fold-thermal-control into main 2026-10-27 14:34:40 +00:00
Owner

Summary

ThermalControlMixin (2 methods) folds into CapacitiesMixin — same actuation domain (capacity switch / pilot-wire / thermal-mode vs thermal-control configs):

_thermal_control.py (deleted)
├── get_thermal_control ──► _capacities.py, CapacitiesMixin
└── set_thermal_control ──► _capacities.py, CapacitiesMixin

client.py: ThermalControlMixin import + base removed (16 → 15 mixins)

Evidence

  • Before: thermal-control lives in its own thin mixin despite sharing the actuation domain with capacities (#151 audit).
    After: both methods live in CapacitiesMixin; no test monkeypatches the deleted module (verified), pytest -q → 242 passed unchanged, mypy → clean.

Merge Danger

Door: two-way

Blast Radius: none — public API unchanged (client.get_thermal_control / client.set_thermal_control identical); rebases trivially against the sibling consolidation PRs (only the client.py bases line overlaps).

Closes the thermal-control part of #176. Part of the #151 audit consolidation.

## Summary `ThermalControlMixin` (2 methods) folds into `CapacitiesMixin` — same actuation domain (capacity switch / pilot-wire / thermal-mode vs thermal-control configs): ```text _thermal_control.py (deleted) ├── get_thermal_control ──► _capacities.py, CapacitiesMixin └── set_thermal_control ──► _capacities.py, CapacitiesMixin client.py: ThermalControlMixin import + base removed (16 → 15 mixins) ``` ## Evidence - **Before:** thermal-control lives in its own thin mixin despite sharing the actuation domain with capacities (#151 audit). **After:** both methods live in `CapacitiesMixin`; no test monkeypatches the deleted module (verified), `pytest -q` → 242 passed unchanged, `mypy` → clean. ## Merge Danger **Door:** two-way **Blast Radius:** none — public API unchanged (`client.get_thermal_control` / `client.set_thermal_control` identical); rebases trivially against the sibling consolidation PRs (only the `client.py` bases line overlaps). Closes the thermal-control part of #176. Part of the #151 audit consolidation.
♻️ refactor: fold ThermalControlMixin into CapacitiesMixin
All checks were successful
Tests / forgejo-pytest (push) Successful in 54s
Tests / forgejo-pytest (pull_request) Successful in 44s
d737c4dbd5
mat force-pushed refactor/fold-thermal-control from d737c4dbd5
All checks were successful
Tests / forgejo-pytest (push) Successful in 54s
Tests / forgejo-pytest (pull_request) Successful in 44s
to f7af615061
Some checks failed
Tests / forgejo-pytest (push) Failing after 41s
Tests / forgejo-pytest (pull_request) Failing after 41s
2026-10-27 14:32:20 +00:00
Compare
mat force-pushed refactor/fold-thermal-control from f7af615061
Some checks failed
Tests / forgejo-pytest (push) Failing after 41s
Tests / forgejo-pytest (pull_request) Failing after 41s
to 9ec1218d25
All checks were successful
Tests / forgejo-pytest (push) Successful in 44s
Tests / forgejo-pytest (pull_request) Successful in 43s
2026-10-27 14:34:34 +00:00
Compare
mat changed title from WIP: ♻️ refactor: fold ThermalControlMixin into CapacitiesMixin to ♻️ refactor: fold ThermalControlMixin into CapacitiesMixin 2026-10-27 14:34:39 +00:00
mat merged commit 9d4923556f into main 2026-10-27 14:34:40 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
mat/python-comwatt-client!193
No description provided.